[PATCHSET] samba-tool sites/subnets administration

Roel van Meer roel at 1afa.com
Mon Jul 13 12:58:50 UTC 2015


Andrew Bartlett writes:

> On Thu, 2015-07-09 at 15:54 +0200, Roel van Meer wrote:

> > attached are four patches that extend the functionality of samba-tool with
> > some commands for administration of sites and subnets.  After these  
> patches,
> > we have the following subcommands in the "samba-tool sites" command:
> >
> > [...]
>
> Thanks for taking the time to patch samba-tool!  I know some folks will
> be particularly keen to see the moveserver command.
>
> I'm confused however, I can't see the patches to extend
> python/samba/sites.py, which seem to be required for these.

I've followed the current code that handles sites and the list command is  
only coded in python/samba/netcmd/sites.py. Patches 3 and 4 do extend  
python/samba/sites.py.

> Also, can you please add some tests in our selftest system for this?
>
> One example you could follow (or extend) for moveserver would be:
> testprogs/blackbox/renamedc.sh but we may also need to write a test for
> a runtime environment as well (to ensure that the running server still
> works post-move).
>
> The other tests might be better using the code that can check for
> expected values in:
>
> python/samba/tests/samba_tool/user.py
>
> Finally, make sure you sign off your patches, and if you are doing this
> work for a company, make sure you send in the Developer Certificate of
> Origin per https://devel.samba.org/samba/devel/copyright-policy.html

Thanks for the feedback!

I'll see about the tests and repost.

Regards,

Roel




More information about the samba-technical mailing list