[PATCH 1/2] Fix MSDFS with POSIX paths in vfs_dfs_samba4

Jeremy Allison jra at samba.org
Thu Jul 9 23:50:11 UTC 2015


On Thu, Jul 09, 2015 at 09:20:12PM +0100, Robin McCorkell wrote:
> Allow for POSIX path separators when parsing a DFS query string
> 
> Signed-off-by: Robin McCorkell <rmccorkell at karoshi.org.uk>

Both patches Reviewed-by: Jeremy Allison <jra at samba.org>

Can I get a second Team reviewer for these two ?

> ---
>  dfs_server/dfs_server_ad.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/dfs_server/dfs_server_ad.c b/dfs_server/dfs_server_ad.c
> index 3d93e19..7e08de4 100644
> --- a/dfs_server/dfs_server_ad.c
> +++ b/dfs_server/dfs_server_ad.c
> @@ -801,6 +801,7 @@ NTSTATUS dfs_server_ad_get_referrals(struct loadparm_context *lp_ctx,
>  	const char *netbios_name;
>  	const char *dns_name;
>  	const char **netbios_aliases;
> +	char path_separator;
>  
>  	if (!lpcfg_host_msdfs(lp_ctx)) {
>  		return NT_STATUS_FS_DRIVER_REQUIRED;
> @@ -828,16 +829,18 @@ NTSTATUS dfs_server_ad_get_referrals(struct loadparm_context *lp_ctx,
>  		return NT_STATUS_NO_MEMORY;
>  	}
>  
> -	while(*server_name && *server_name == '\\') {
> +	path_separator = (*server_name == '/') ? '/' : '\\';
> +
> +	while(*server_name && *server_name == path_separator) {
>  		server_name++;
>  	}
>  
> -	dfs_name = strchr(server_name, '\\');
> +	dfs_name = strchr(server_name, path_separator);
>  	if (dfs_name != NULL) {
>  		dfs_name[0] = '\0';
>  		dfs_name++;
>  
> -		link_path = strchr(dfs_name, '\\');
> +		link_path = strchr(dfs_name, path_separator);
>  		if (link_path != NULL) {
>  			link_path[0] = '\0';
>  			link_path++;
> -- 
> 2.4.5



More information about the samba-technical mailing list