[PATCH] notifyd

[Michael Adam]

On 2015-07-08 at 07:45 +0200, Stefan (metze) Metzmacher wrote:
> Am 07.07.2015 um 22:50 schrieb Jeremy Allison:
> > On Tue, Jul 07, 2015 at 10:48:05PM +0200, Stefan (metze) Metzmacher wrote:
> >> Am 07.07.2015 um 21:22 schrieb Jeremy Allison:
> >>> On Tue, Jul 07, 2015 at 09:07:46PM +0200, Volker Lendecke wrote:
> >>>> On Tue, Jul 07, 2015 at 12:02:47PM -0700, Jeremy Allison wrote:
> >>>>>> Attached find two files: One with the changes just for review, and one
> >>>>>> with the full new version.
> >>>>>
> >>>>> Pushed with minor change to "smbd: Remove SMB_VFS_NOTIFY_WATCH" commit
> >>>>> to add version number comment /* Version 33 - Remove notify_watch_fn */
> >>>>> to source3/include/vfs.h.
> >>>>>
> >>>>> W00t! Amazing work, now in for 4.3.0 !!!!!
> >>>>
> >>>> Wait -- can we get a second ack on this before we push? This
> >>>> is too large a change for just a single reviewer! Not that I
> >>>> don't trust you, but the bus factor is way too low for this
> >>>> if only me and you have taken a look.
> >>>
> >>> I did do the autobuild push already (not sure how to cancel that).
> >>>
> >>> Personally I feel this is no larger than the spotlight code which
> >>> just went in with only 2 reviewers :-), and I'm guessing that what
> >>> you really mean here is you want metze to look :-).
> >>
> >> Looking briefly I found a bug in source3/wscript_build
> >> if bld.env['dmapi_lib'] is not empty
> >> the build fails with unknown dependency to 'dmfam', there's a missing
> >> whitespace.
> >>
> >> I'll continue tomorrow...
> > 
> > Well if the autobuild goes through, just post patches
> > for the build system on top and I'll review.
> 
> Ok, here's the fix.
> 
> Please review and push.

pushed.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150708/3d841c8e/attachment.pgp>