[PATCH] notifyd

[Jeremy Allison]

On Tue, Jul 07, 2015 at 09:07:46PM +0200, Volker Lendecke wrote:
> On Tue, Jul 07, 2015 at 12:02:47PM -0700, Jeremy Allison wrote:
> > > Attached find two files: One with the changes just for review, and one
> > > with the full new version.
> > 
> > Pushed with minor change to "smbd: Remove SMB_VFS_NOTIFY_WATCH" commit
> > to add version number comment /* Version 33 - Remove notify_watch_fn */
> > to source3/include/vfs.h.
> > 
> > W00t! Amazing work, now in for 4.3.0 !!!!!
> 
> Wait -- can we get a second ack on this before we push? This
> is too large a change for just a single reviewer! Not that I
> don't trust you, but the bus factor is way too low for this
> if only me and you have taken a look.

I did do the autobuild push already (not sure how to cancel that).

Personally I feel this is no larger than the spotlight code which
just went in with only 2 reviewers :-), and I'm guessing that what
you really mean here is you want metze to look :-).

If so, get him to cancel my autobuild and schedule him to spend
some time on it.

Also, this code has been in production on a site for a long
time now, so this increases my confidence in it.

I will leave the call to you, but personally I'm good with
this code going into master and if we find some bugs later,
we'll just patch as normal.