[PATCH] librpc: Fix a "ignoring asprint return" warning

Volker Lendecke Volker.Lendecke at SerNet.DE
Tue Jul 7 13:41:45 UTC 2015


Hi!

Review&push appreciated!

Thanks,

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de
-------------- next part --------------
From 2ef54ca7756a83db702436d6d9fc0ec356cf266b Mon Sep 17 00:00:00 2001
From: Volker Lendecke <vl at samba.org>
Date: Tue, 7 Jul 2015 15:36:07 +0200
Subject: [PATCH] librpc: Fix a "ignoring asprint return" warning

Signed-off-by: Volker Lendecke <vl at samba.org>
---
 source4/librpc/rpc/dcerpc.c |   10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/source4/librpc/rpc/dcerpc.c b/source4/librpc/rpc/dcerpc.c
index 6e3410b..6ce0d35 100644
--- a/source4/librpc/rpc/dcerpc.c
+++ b/source4/librpc/rpc/dcerpc.c
@@ -485,10 +485,12 @@ static void dcerpc_bh_ndr_pull_failed(struct dcerpc_binding_handle *h,
 
 	for (i=0;i<num_examples;i++) {
 		char *name=NULL;
-		asprintf(&name, "%s/rpclog/%s-out.%d",
-			 hs->p->conn->packet_log_dir,
-			 call->name, i);
-		if (name == NULL) {
+		int ret;
+
+		ret = asprintf(&name, "%s/rpclog/%s-out.%d",
+			       hs->p->conn->packet_log_dir,
+			       call->name, i);
+		if (ret == -1) {
 			return;
 		}
 		if (!file_exist(name)) {
-- 
1.7.9.5



More information about the samba-technical mailing list