[PATCH] sharesec: Remove error message for unmarshall_sec_desc failure

Jeremy Allison jra at samba.org
Mon Jul 6 19:55:17 CEST 2015


On Fri, Jul 03, 2015 at 06:49:10AM +0200, Volker Lendecke wrote:
> On Thu, Jul 02, 2015 at 12:49:19PM -0700, Christof Schmitt wrote:
> > Just an additional remark: unmarshall_sec_desc still prints an error, in
> > case the tdb entry is not empty, but cannot be parsed:
> 
> This is about ctdb not treating 0-length and nonexisting
> records differently, right? My opinion here is that we
> should not call unmarshall_security_descriptor from
> get_share_security() if the record is 0-sized and not
> suppress the error message if it failed.
> 
> You patch certainly achieves something similar, so that's
> just my taste.

I think Christof's patch is ok, as it does
push any record (whether zero length or not)
through unmarshall_security_descriptor which
would be the right thing to do if ctdb does
end up treating 0-length and nonexisting
records differently at some point.

So just a quick question, why does ctdb
return a zero-length record in this case ?


More information about the samba-technical mailing list