[PATCH] sharesec: Remove error message for unmarshall_sec_desc failure

Volker Lendecke Volker.Lendecke at SerNet.DE
Fri Jul 3 06:49:10 CEST 2015


On Thu, Jul 02, 2015 at 12:49:19PM -0700, Christof Schmitt wrote:
> Just an additional remark: unmarshall_sec_desc still prints an error, in
> case the tdb entry is not empty, but cannot be parsed:

This is about ctdb not treating 0-length and nonexisting
records differently, right? My opinion here is that we
should not call unmarshall_security_descriptor from
get_share_security() if the record is 0-sized and not
suppress the error message if it failed.

You patch certainly achieves something similar, so that's
just my taste.

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de


More information about the samba-technical mailing list