[PATCH] Improve netbios name handling

Andreas Schneider asn at samba.org
Fri Jan 30 09:29:38 MST 2015


On Thursday 22 January 2015 13:09:48 Stefan  Metzmacher wrote:
> Hi Andreas,

Hi Metze,

> > attached is a patch which shortens netbios names to the correct length.
> > 
> > This should improve usability.
> > 
> > Review and push appreciated :)
> 
> Isn't that a potential security problem
> if we change the desired hostname and connect to someone else?
> 
> I think we should not try nbt name lookups in this case.

you're right. Here is an improved patchset.


	-- andreas

-- 
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
www.samba.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: wurst.patch
Type: text/x-patch
Size: 5534 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150130/11d0ccf4/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150130/11d0ccf4/attachment.pgp>


More information about the samba-technical mailing list