[SCM] New address sanitizer option

[Ira Cooper]

On Thu, Jan 29, 2015 at 3:24 AM, Andrew Bartlett <abartlet at samba.org> wrote:

> On Thu, 2015-01-29 at 08:32 +0100, Andreas Schneider wrote:
> > On Wednesday 28 January 2015 19:45:03 Andreas Schneider wrote:
> > > The branch, master has been updated
> > >
> > > commit cf68c1accb50f4d8449e993c630559a3d3e9dd36
> > > Author: Andreas Schneider <asn at samba.org>
> > > Date:   Mon Jan 26 16:16:15 2015 +0100
> > >
> > >     waf: Add address sanitizer configure option.
> > >
> > >     Signed-off-by: Andreas Schneider <asn at samba.org>
> > >     Reviewed-by: Stefan Metzmacher <metze at samba.org>
> > >
> >
> > Hi,
> >
> > check out ./configure --address-sanitizer
> >
> >
> > uid_wrapper should be protected now.
>
> BTW, Garming has been working over the codebase working to make us pass
> ubsan, the undefined behaviour sanitizer.  I'll let him speak to his
> work once he has cleaned it up and we have looked over the changes for
> correctness, but I wanted to mention it to avoid someone else
> duplicating the effort.
>


I was considering a far "harsher" option.  Because almost every tool of
this type has some form of a hole, initializing ALL variables in the
codebase.

It is much simpler to see that a variable is initialized, than "did we get
this one.. and this one... what about this strange corner case..."

Meh... get 'em all!  If there is a performance issue, let's address it
AFTER with, patches that loosen the restriction and have comments.

My thoughts,

-Ira