Your Tombstone Reanimation branch

Kamen Mazdrashki kamenim at samba.org
Wed Jan 28 17:03:12 MST 2015


Hi Andrew,

Please find update branch version that should pass tests in autobuild
(full autobuild is in progress, but running tests by hand is working now)
https://github.com/kamenim/samba/pull/2

I have modified already reviewed commit to add value for "logonCount"

Cheers,
Kamen


On Mon, Jan 26, 2015 at 12:13 AM, Kamen Mazdrashki <kamenim at samba.org>
wrote:

>
>
> On Sun, Jan 25, 2015 at 11:51 PM, Andrew Bartlett <abartlet at samba.org>
> wrote:
>
>> This is looking much better.  Can you also do:
>>
>> On Sun, 2015-01-25 at 21:41 +0200, Kamen Mazdrashki wrote:
>> > +        # assert we have expected attribute names
>> > +        actual_names = set(user_obj.keys())
>> > +        # Samba does not use 'dSCorePropagationData', so skip it
>> > +        actual_names -= set(['dSCorePropagationData'])
>> > +        self.assertSetEqual(set(expected_attrs.keys()), actual_names)
>>
>> On the reanimation tests?
>>
>
> It should be there already
> Actually I think I've copy&pasted from there :)
>
> Cheers,
> Kamen
>


More information about the samba-technical mailing list