Thoughts on correct support for Windows Previous versions

Richard Sharpe realrichardsharpe at gmail.com
Tue Jan 27 20:08:12 MST 2015


On Tue, Jan 27, 2015 at 4:38 PM, ronnie sahlberg
<ronniesahlberg at gmail.com> wrote:
> -Wall -Werror is what the doctor orders
>
> On Tue, Jan 27, 2015 at 4:17 PM, Satyajit Deshmukh
> <satyaji.deshmuk at nutanix.com> wrote:
>> A minor correction is needed in the patch attached previously-
>> diff --git a/source3/smbd/trans2.c b/source3/smbd/trans2.c
>> index 16498b3..57d7bde 100644
>> --- a/source3/smbd/trans2.c
>> +++ b/source3/smbd/trans2.c
>> .....
>> +                       /*
>> +                        * If the file is a previous version, Windows expects
>> +                        * FS_INFO to indicate that it is on an ROFS.
>> +                        */
>> +                       if (fsp && fsp->is_previous_version &&
>> +                           !fsp->is_directory)
>> +                               additional_flags != FILE_READ_ONLY_VOLUME;
>>
>> I believe it should be-
>> additional_flags |= FILE_READ_ONLY_VOLUME;

Yeah ...

-- 
Regards,
Richard Sharpe
(何以解憂?唯有杜康。--曹操)


More information about the samba-technical mailing list