[PATCH 6/8] urgent_replication: Use subunit reporting, remove allow_empty_output.

Stefan (metze) Metzmacher metze at samba.org
Mon Jan 26 03:07:04 MST 2015

Am 26.01.2015 um 10:50 schrieb Jelmer Vernooij:
> I don't understand why we would be converting the URL to lowercase here. Your fix seems reasonable to me. Why do we need to still convert to lowercase in the paged searches case?

Before we had

if samdb_url.lower().startswith("ldap://"):


See commit f1b3c4dd387ac04615c3443d5de1059d2dc59ba4
  Author: Kamen Mazdrashki <kamenim at samba.org>
  Date:   Sun Sep 26 02:13:39 2010 +0300

    s4-possibleinferiors.py: Fix usage of 'paged_search' module for
remote LDB connections

This means LDAP:// might also be supposed to work, but
ldb_module_connect_backend() only handles 'ldap://'.

I'm also fine with removing only the "samdb_url = samdb_url.lower()" line
and drop support for 'LDAP://'.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150126/1da6b1c7/attachment.pgp>

More information about the samba-technical mailing list