A question about use of DEBUG in wb_reqtrans.c

[Noel Power]

Hi Metz, All

Recently I was looking at a problem where the root cause would have
easily been seen if the DEBUG messages in wb_reqtrans.c were functional.
I missed entirely that the DEBUG macro was disabled at the top of the
file and because of that for a while ended up on a wild goose chase ;-)
Afterwards my first thought was if those DEBUG messages are not
functional then it's better to remove them entirely (rather than cause
confusion). However, it would be nicer of course if they could be enabled.

The commit that seemed to remove that functionality was
https://git.samba.org/?p=samba.git;a=commit;h=faabc97c9adffd9468a5d1606467359a81445cf3

I wonder though if the reason disabling the DEBUG macro in this file is
still relevant (perhaps it isn't)

looking at the current usage in master wb_reqtrans.c

wb_reqtrans.c is used in
    a) LIBWBCLIENT_OLD (source4/libcli/wbclient/wscript_build) library
    b) winbindd (source3/wscript_build)
    c) smbtorture (source3/wscript_build)

LIBEBCLIENT_OLD is used

./source4/auth/ntlm/wscript_build
./source4/auth/wscript_build
./source4/ntvfs/posix/wscript_build
./source4/rpc_server/wscript_build

afaics all of the targets above either already link in objects that
already contain the DEBUG or reference DEBUG macros directly themselves
so I don't really see an issue enabling it. So is it ok to try reenable
the messages ?, get rid of them ? (patches for either option attached)
or is there another alternative

Noel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-remove-non-functional-DEBUG-messages.patch
Type: text/x-patch
Size: 1835 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150123/e86c2096/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-make-DEBUG-macro-functional-again.patch
Type: text/x-patch
Size: 938 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150123/e86c2096/attachment-0001.bin>