[PATCH] Fix a memory leak in pam_smbpass

Andreas Schneider asn at samba.org
Thu Jan 22 07:33:55 MST 2015

On Thursday 22 January 2015 12:14:15 Volker Lendecke wrote:
> On Thu, Jan 22, 2015 at 10:45:06AM +0100, Andreas Schneider wrote:
> > Hello,
> > 
> > attached is a patch which correctly frees memory allocated by
> > pam_sm_authenticate().
> > 
> > Review and push appreciated!
> R-b: Me, although free() deals fine with NULL, so the if-statement in
> ret_data_cleanup isn't necessary.

I will change that and push with your RB+.
> This triggers one question: Is pam_smbpass really going to be maintained
> in the future? Isn't pam_winbind with winbind running locally much better?

I have at least one customer using it. I guess they should migrate to 
something else but for now we should fix bugs.

	-- andreas

Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org

More information about the samba-technical mailing list