[PATCH] Fix a memory leak in pam_smbpass

Volker Lendecke Volker.Lendecke at SerNet.DE
Thu Jan 22 04:14:15 MST 2015

On Thu, Jan 22, 2015 at 10:45:06AM +0100, Andreas Schneider wrote:
> Hello,
> attached is a patch which correctly frees memory allocated by 
> pam_sm_authenticate().
> Review and push appreciated!

R-b: Me, although free() deals fine with NULL, so the if-statement in
ret_data_cleanup isn't necessary.

This triggers one question: Is pam_smbpass really going to be maintained
in the future? Isn't pam_winbind with winbind running locally much better?


SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de

More information about the samba-technical mailing list