[PATCH] Remove use of the "staticforward" macro

Jelmer Vernooij jelmer at samba.org
Tue Jan 20 07:07:14 MST 2015

On Tue, Jan 20, 2015 at 01:59:25PM +0100, Petr Viktorin wrote:
> On 01/16/2015 09:41 PM, Jelmer Vernooij wrote:
> >On Fri, Jan 16, 2015 at 07:30:18PM +0100, Petr Viktorin wrote:
> >>Hello,
> >>The "staticforward" macro is defined as "static" everywhere since Python
> >>2.3, and only exists "for source compatibility with old C extensions"
> >>(according to Include/object.h in Python source).
> >>As Python doesn't support compilers that need this workaround, I think Samba
> >>can discontinue using it.
> >
> >Reviewed-By: Jelmer Vernooij <jelmer at samba.org>
> Thanks for the review!
> I forgot the sign-off line, apologies for that. Here is the same patch,
> signed off.

Thanks! We'll need another Samba developer to also approve, and hopefully
they can also push this commit to autobuild.



More information about the samba-technical mailing list