[PATCH] libwbclient clear pointer on bad read
Andreas Schneider
asn at samba.org
Tue Jan 20 00:08:11 MST 2015
On Monday 19 January 2015 20:30:37 Matthew Newton wrote:
> Hi,
>
> On Sun, Jan 18, 2015 at 04:26:41PM +0100, Stefan (metze) Metzmacher wrote:
> > Am 17.01.2015 um 02:44 schrieb Matthew Newton:
> > > + if ((fd_info = winbindd_fd_info()) == NULL) {
> > > + return;
> > > + }
> >
> > Can you please change all changes like this into two lines:
> >
> > fd_info = winbindd_fd_info();
> > if (fd_info == NULL) {
> > ...
>
> Updated patches attached.
>
> I've now tested this on a FreeRADIUS server and it's working fine:
> over 22,000 auths, peaking at 15 per second with 5 threads. I just
> can't test the irix bit.
Great work, thanks. Could you please make is_privileged a bool? :)
Cheers,
-- andreas
--
Andreas Schneider GPG-ID: CC014E3D
Samba Team asn at samba.org
www.samba.org
More information about the samba-technical
mailing list