[PATCH] libwbclient clear pointer on bad read

Matthew Newton mcn4 at leicester.ac.uk
Mon Jan 19 13:30:37 MST 2015


Hi,

On Sun, Jan 18, 2015 at 04:26:41PM +0100, Stefan (metze) Metzmacher wrote:
> Am 17.01.2015 um 02:44 schrieb Matthew Newton:
> > +	if ((fd_info = winbindd_fd_info()) == NULL) {
> > +		return;
> > +	}
> 
> Can you please change all changes like this into two lines:
> 
> fd_info = winbindd_fd_info();
> if (fd_info == NULL) {
> ...

Updated patches attached.

I've now tested this on a FreeRADIUS server and it's working fine:
over 22,000 auths, peaking at 15 per second with 5 threads. I just
can't test the irix bit.

Thanks!

Matthew


-- 
Matthew Newton, Ph.D. <mcn4 at le.ac.uk>

Systems Specialist, Infrastructure Services,
I.T. Services, University of Leicester, Leicester LE1 7RH, United Kingdom

For IT help contact helpdesk extn. 2253, <ithelp at le.ac.uk>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Convert-wb_common.c-global-variables-into-a-struct.patch
Type: text/x-diff
Size: 4338 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150119/84c72b67/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Get-pointers-to-winbind-fd-global-from-function.patch
Type: text/x-diff
Size: 4963 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150119/84c72b67/attachment-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Add-thread-support-to-wb_common.c.patch
Type: text/x-diff
Size: 2715 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150119/84c72b67/attachment-0002.patch>


More information about the samba-technical mailing list