[PATCH] s3-vfs: handle calling chdir after disconnect

Jeremy Allison jra at samba.org
Thu Jan 15 13:42:49 MST 2015


On Thu, Jan 15, 2015 at 08:58:42PM +0100, Volker Lendecke wrote:
> On Thu, Jan 15, 2015 at 11:46:01AM -0500, Ira Cooper wrote:
> > I'd argue you are papering over the real problem, which is that Samba
> > shouldn't be doing that in the first place.
> > 
> > Try this patch out, it swaps the two calls in the close_cnum.
> > 
> > (The code is 100% untested!)
> > 
> > Jeremy/Volker, I'd love your eyes on this one.
> 
> Not having tested it I'd say this looks 100% reasonable.
> Accessing "conn" after a call to the DISCONNECT is just
> wrong.

Reviewed-by: Jeremy Allison <jra at samba.org>

also. Obvious goodness !


More information about the samba-technical mailing list