[PATCH] libwbclient clear pointer on bad read

Jeremy Allison jra at samba.org
Thu Jan 15 13:35:02 MST 2015


On Thu, Jan 15, 2015 at 12:30:24PM -0800, Jeremy Allison wrote:
> > FYI, If we're gonne just go pthreads directly, which
> > is looks like we already have - then we should remove
> > all the work I did inside:
> > 
> > source3/libsmb/libsmb_thread_impl.c
> > source3/libsmb/libsmb_thread_posix.c
> > lib/util/smb_threads.c
> > lib/util/smb_threads.h
> > 
> > to wrap this stuff based off the ideas in openssl.
> > 
> > Volker, if you want to propose a patch deleting it
> > all I'll push :-).
> > 
> > (Sad panda. I liked my abstraction layer but it
> > never got used... :-( ).
> 
> Oh - not quite true - it gets initialized
> inside talloc_stackframe_create(), but never
> used after that.

Oh, it's also used inside source3/libsmb/libsmb_context.c
too...

Probably be cleaner just to rip out this abstraction
layer and use pthread calls directly nowadays.


More information about the samba-technical mailing list