splitout of samba-debug (was: Re: [SCM] Samba Shared Repository - branch master updated)
jra at samba.org
Thu Jan 15 11:07:46 MST 2015
On Thu, Jan 15, 2015 at 12:54:53PM +0100, Jelmer Vernooij wrote:
> On Thu, Sep 18, 2014 at 11:03:03PM +0200, Volker Lendecke wrote:
> > via 25df58a lib: Make samba-debug a private library
> > commit 25df58a853d8d3ecab2705687453193cb676976c
> > Author: Volker Lendecke <vl at samba.org>
> > Date: Thu Sep 18 14:50:50 2014 +0200
> > lib: Make samba-debug a private library
> > Signed-off-by: Volker Lendecke <vl at samba.org>
> > Reviewed-by: Jeremy Allison <jra at samba.org>
> This change removes the debug library symbols from our public libraries, making
> them inaccessible to any non-Samba code - including OpenChange. As Julien just
> discovered, this breaks the use of OpenChange with Samba 4.2.
> Can we revert this change, at least for 4.2? We can discuss whether
> OpenChange should use the Samba DEBUG() interface or whether it can do its
> own logging, but that would not be an easy change to make this far in the cycle.
Whilst I'm sympathetic to the needs of OpenChange,
I don't think it's unreasonable to be able to clean
up mistakes made in our own code.
If we can't do that then we will ossify the project
with bad decisions made years ago - that way lies
Solaris (duck before Ira throws bricks at me :-).
Exactly *which* symbols do they need ? Can you
provide the details on exactly what breaks ?
If it's "debug" why are they using our log files,
and not their own ?
Please don't revert Volker's change until we
know the exact problem here.
More information about the samba-technical