splitout of samba-debug (was: Re: [SCM] Samba Shared Repository - branch master updated)

Jelmer Vernooij jelmer at samba.org
Thu Jan 15 04:54:53 MST 2015


On Thu, Sep 18, 2014 at 11:03:03PM +0200, Volker Lendecke wrote:
>        via  25df58a lib: Make samba-debug a private library

> commit 25df58a853d8d3ecab2705687453193cb676976c
> Author: Volker Lendecke <vl at samba.org>
> Date:   Thu Sep 18 14:50:50 2014 +0200
> 
>     lib: Make samba-debug a private library
>     
>     Signed-off-by: Volker Lendecke <vl at samba.org>
>     Reviewed-by: Jeremy Allison <jra at samba.org>
> 

This change removes the debug library symbols from our public libraries, making
them inaccessible to any non-Samba code - including OpenChange. As Julien just
discovered, this breaks the use of OpenChange with Samba 4.2.

Can we revert this change, at least for 4.2? We can discuss whether
OpenChange should use the Samba DEBUG() interface or whether it can do its
own logging, but that would not be an easy change to make this far in the cycle.

Cheers,

Jelmer


More information about the samba-technical mailing list