notifyd

[Jeremy Allison]

On Mon, Jan 12, 2015 at 06:35:43PM +0100, Volker Lendecke wrote:
> On Fri, Jan 09, 2015 at 10:46:48AM -0800, Jeremy Allison wrote:
> > On Fri, Jan 09, 2015 at 05:56:44PM +0100, Volker Lendecke wrote:
> > > Hi!
> > > 
> > > Attached find the notifyd work, rebased on top of current
> > > master. I know it does not have signed-off by tags
> > > everywhere yet, but I think it's in pretty good shape. So
> > > everyone interested in faster clustered change notify with
> > > clustered inotify, please take a look :-)
> > 
> > Wow - this looks some seriously nice code !
> > 
> > The only thing I'd ask for is some more comments
> > inside smbd_notifyd_init() to point out we're
> > starting a new daemon here.
> > 
> > I'm assuming I can just push the first two patches...
> > 
> > What do you need to get patches 3-15 in master ?
> 
> The main thing is: I'd like to go through the code with
> someone. In particular the cluster replication engine has
> some subtleties. Also, I'm not sure that we can make this
> switch without a fall back in case something serious
> happens that I did not foresee. I firmly believe it works
> better than it did with the old code, but a patch that says
> 
> 33 files changed, 2633 insertions(+), 2039 deletions(-)

It's the deletions bit I love :-).

> is a bit scary to me :-)

Yeah, I understand. Do you want to schedule some time
to go through it with myself and metze ?

The leases code was bigger, so I'm sure we can get
this done :-).