CTDB could be more helpful to those of us getting CTDB working on a new file system

[Richard Sharpe]

On Thu, Jan 8, 2015 at 3:20 PM, Michael Adam <obnox at samba.org> wrote:
> On 2015-01-08 at 14:08 -0800, Richard Sharpe wrote:
>> Hi folks,
>>
>> All of a sudden, with a new configuration, we started getting this in
>> the ctdb log file:
>>
>> 2015/01/08 09:54:25.239333 [recoverd: 5824]: ctdb_recovery_lock:
>> Failed to get recovery lock on '/var/hf/hfmp/somedir/ctdb_reclock'
>> 2015/01/08 09:54:25.239357 [recoverd: 5824]: Unable to get recovery
>> lock - retrying recovery
>>
>> Things were working correctly on another two-node setup.
>>
>> After testing with ping_pong it turned out that the problem is that
>> the file system is returning EBADF when a lock is attempted, which is
>> our problem, but it certainly would have been nice for CTDB to tell us
>> that.
>
> A patch to improve the helpfulness of the debug message
> would have been highly welcome. ;-)

You are correct. I was in a bad mood.

> Like the attached (for master) - review appreciated.

LGTM.

Reviewed-by: Richard Sharpe <rsharpe at samba.org>

-- 
Regards,
Richard Sharpe
(何以解憂？唯有杜康。--曹操)