[PATCH] New VFS Module "unityed_media" for sharing AVID projects

[Jeremy Allison]

On Tue, Dec 30, 2014 at 11:06:24AM +0100, Ralph Böhme wrote:
> On Fri, Dec 19, 2014 at 10:01:42PM +0100, Ralph Böhme wrote:
> > Hi Jeremy,
> > 
> > On Tue, Dec 16, 2014 at 03:20:07PM -0800, Jeremy Allison wrote:
> > > On Mon, Dec 08, 2014 at 06:55:35PM +0100, Ralph Böhme wrote:
> > > > Hi all,
> > > > 
> > > > attached is a new VFS module for improved AVID project sharing, from
> > > > the commit message:
> > > > It's been tested by 3rd party and reported to work flawlessly. Please
> > > > review, comment and/or push if ok.
> > > 
> > > First comment/fix needed.
> > > 
> > > get_digit_group() walks through a pathname using:
> > > 
> > > +       while (*p) {
> > > +               if (isdigit(*p)) {
> > > +                       *digit = (uintmax_t)strtoul(p, &endp, 10);
> > > +                       DEBUG(10, ("num_suffix = '%ju'\n",
> > > +                                             *digit));
> > > +                       return true;
> > > +               }
> > > +               p++;
> > > +       }
> > > 
> > > This won't work for non-ASCII files. Use next_codepoint()
> > > to walk through pathname strings.
> > 
> > thanks, will fix and resubmit.
> 
> updated patch attached.

Sorry - just noticed one more thing.

Use of strstr() in path processing inside alloc_get_client_path().

This must be strstr_m() for MB correctness.

I would just fix and autobuild, but I can't
test this so I'm hoping you can do that and
then re-submit to me.

Sorry,

Jeremy.