[PATCHES] lib/util - cleanups, build restructuring, charset compatibility
martin at meltin.net
Thu Jan 8 11:18:50 MST 2015
On Thu, 08 Jan 2015 10:27:06 +0100, Andreas Schneider <asn at samba.org>
> On Thursday 08 January 2015 20:05:22 Martin Schwenke wrote:
> > On Wed, 07 Jan 2015 17:40:26 +0100, Andreas Schneider <asn at samba.org>
> > wrote:
> > > I think SMB_ASSERT should only be defined if the samba macro is available.
> > > This means debug.h should have #define SAMBA_DEBUG 1
> > >
> > > #ifdef SAMBA_DEBUG
> > > #define SMB_ASSERT() ...
> > > #endif
> > debug.h already defines _DEBUG_H. Perhaps we should change that to
> > _SAMBA_DEBUG_H_ for consistency with other headers and test that in
> > fault.h?
> The attached patch should address the issue.
Reviewed-by: Martin Schwenke <martin at meltin.net>
Pushed to autobuild. Please re-push if it doesn't make it through...
peace & happiness,
More information about the samba-technical