[PATCH] vfs_fruit: Fix a talloc hierarchy error

Volker Lendecke Volker.Lendecke at SerNet.DE
Thu Jan 8 05:08:18 MST 2015


On Thu, Jan 08, 2015 at 11:41:03AM +0100, Ralph Böhme wrote:
> On Wed, Jan 07, 2015 at 10:18:43PM +0100, Volker Lendecke wrote:
> > On Wed, Jan 07, 2015 at 07:01:11PM +0100, Ralph Böhme wrote:
> > > On Wed, Jan 07, 2015 at 12:04:29PM +0100, Ralph Böhme wrote:
> > > > On Wed, Jan 07, 2015 at 11:48:57AM +0100, Volker Lendecke wrote:
> > > > > Hi!
> > > > > 
> > > > > Review&push appreciated!
> > > > 
> > > > good catch, pushed! Thanks!
> > > 
> > > looks like this breaks samba3.vfs.fruit. I'll look into it.
> > > <https://git.samba.org/slow/samba-autobuild/samba.stdout>
> > 
> > Yes, working on this. We get a sharing violation in the write metadata
> > test, and smbtorture goes into the sleep(1000000). Something really
> > weird is going on. I'm working on this as well.
> > 
> > I'd assert though that my patch does fix *something*. It might uncover
> > a deeper bug, but the valgrind error is gone.
> 
> here's the correct patch plus a small enhancement for the torture test.
> 
> Please review&push if ok.

Thanks, pushed.

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de


More information about the samba-technical mailing list