[PATCH] vfs_fruit: Fix a talloc hierarchy error
rb at sernet.de
Thu Jan 8 03:07:22 MST 2015
On Wed, Jan 07, 2015 at 10:18:43PM +0100, Volker Lendecke wrote:
> On Wed, Jan 07, 2015 at 07:01:11PM +0100, Ralph Böhme wrote:
> > On Wed, Jan 07, 2015 at 12:04:29PM +0100, Ralph Böhme wrote:
> > > On Wed, Jan 07, 2015 at 11:48:57AM +0100, Volker Lendecke wrote:
> > > > Hi!
> > > >
> > > > Review&push appreciated!
> > >
> > > good catch, pushed! Thanks!
> > looks like this breaks samba3.vfs.fruit. I'll look into it.
> > <https://git.samba.org/slow/samba-autobuild/samba.stdout>
> Yes, working on this. We get a sharing violation in the write metadata
> test, and smbtorture goes into the sleep(1000000). Something really
> weird is going on. I'm working on this as well.
Fwiw, this is the torture invocation you can use:
$ ./bin/smbtorture -U ralph%passwd --option=torture:share1=AAPL --option=torture:share2=AAPL --option=torture:localdir=/share/aapl //localhost/AAPL vfs.fruit
$ grep -A 3 AAPL /opt/samba/etc/smb.conf
path = /share/aapl
vfs objects = catia fruit streams_xattr
> I'd assert though that my patch does fix *something*. It might uncover
> a deeper bug, but the valgrind error is gone.
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
More information about the samba-technical