[PATCHES] lib/util - cleanups, build restructuring, charset compatibility

Andreas Schneider asn at samba.org
Thu Jan 8 02:27:06 MST 2015


On Thursday 08 January 2015 20:05:22 Martin Schwenke wrote:
> On Wed, 07 Jan 2015 17:40:26 +0100, Andreas Schneider <asn at samba.org>
> 
> wrote:
> > I think SMB_ASSERT should only be defined if the samba macro is available.
> > This means debug.h should have #define SAMBA_DEBUG 1
> > 
> > #ifdef SAMBA_DEBUG
> > #define SMB_ASSERT() ...
> > #endif
> 
> debug.h already defines _DEBUG_H.  Perhaps we should change that to
> _SAMBA_DEBUG_H_ for consistency with other headers and test that in
> fault.h?

The attached patch should address the issue.


	-- andreas

-- 
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
www.samba.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: debug_macro.patch
Type: text/x-patch
Size: 1525 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150108/51834662/attachment.bin>


More information about the samba-technical mailing list