Patch: Add a script-only module
jra at samba.org
Wed Jan 7 17:53:25 MST 2015
On Wed, Jan 07, 2015 at 04:41:11PM -0800, Richard Sharpe wrote:
> On Wed, Jan 7, 2015 at 4:37 PM, Jeremy Allison <jra at samba.org> wrote:
> > On Wed, Jan 07, 2015 at 02:56:19PM -0800, Richard Sharpe wrote:
> >> Attached is the new patch that addresses Jeremy's last concern.
> >> --
> >> Regards,
> >> Richard Sharpe
> >> (何以解憂？唯有杜康。--曹操)
> >> From 091a7ea4ec901d7eacf177b880022f6ff56b7c53 Mon Sep 17 00:00:00 2001
> >> From: Richard Sharpe <realrichardsharpe at gmail.com>
> >> Date: Tue, 23 Dec 2014 17:33:34 -0800
> >> Subject: [PATCH] Add a script-only idmap module.
> >> In this third version I have cleaned up some unused variable warnings that
> >> only the Samba 3 build found and added a man page based on the idmap_tdb2
> >> man page. I have also added support for ID_TYPE_BOTH mappings and replaced
> >> calls to popen with something safer. Also, I removed some non-PC macros.
> > LGTM - pushed. I'd love to have some tests for this though so
> > it doesn't bit-rot - is there an easy way you can see to add
> > some tests ?
> OK, let me think about this a bit. I am sure there is a way.
Ah, autobuild failed due to some warnings (strange, I thought
I had the same compiler set up as autobuild...).
Will fix and resubmit.
More information about the samba-technical