Patch: Add a script-only module
jra at samba.org
Wed Jan 7 17:37:23 MST 2015
On Wed, Jan 07, 2015 at 02:56:19PM -0800, Richard Sharpe wrote:
> Attached is the new patch that addresses Jeremy's last concern.
> Support Charlie Hebdo!
> Richard Sharpe
> From 091a7ea4ec901d7eacf177b880022f6ff56b7c53 Mon Sep 17 00:00:00 2001
> From: Richard Sharpe <realrichardsharpe at gmail.com>
> Date: Tue, 23 Dec 2014 17:33:34 -0800
> Subject: [PATCH] Add a script-only idmap module.
> In this third version I have cleaned up some unused variable warnings that
> only the Samba 3 build found and added a man page based on the idmap_tdb2
> man page. I have also added support for ID_TYPE_BOTH mappings and replaced
> calls to popen with something safer. Also, I removed some non-PC macros.
LGTM - pushed. I'd love to have some tests for this though so
it doesn't bit-rot - is there an easy way you can see to add
some tests ?
More information about the samba-technical