RFC patch to allow servicepack param to be passed to net ads join cmd

Jeremy Allison jra at samba.org
Wed Jan 7 13:34:05 MST 2015

On Wed, Jan 07, 2015 at 04:09:20PM +0100, David Disseldorp wrote:
> On Wed, 07 Jan 2015 12:41:27 +0000, Noel Power wrote:
> > I wanted to pass the osVer and osName attributes when joining via 'net
> > ads join' so that the Windows AD Server shows that information in the
> > Operating System [*] tab of the newly joined computer account. However
> > by default the samba version is shown in the 'Service pack' field. The
> > service pack information is sent automatically, it's not currently
> > possibly to change what is sent. To offer more flexibility this patch
> > adds the ability to specify an additional parameter as part of the 'net
> > ads join' cmd to set
> > a value for the service pack field, (if the new param is not specified
> > previous behaviour is preserved and the samba version is used)
> > 
> > e.g. net ads -UAdministrator join osVer='13.2' osName='openSUSE' 
> > osServicePack=''
> This patch looks fine to me.
> Reviewed-by: David Disseldorp <ddiss at samba.org>

LGTM - thanks Noel ! Pushed to autobuild.

More information about the samba-technical mailing list