[PATCHES] lib/util - cleanups, build restructuring, charset compatibility

Martin Schwenke martin at meltin.net
Tue Jan 6 12:26:47 MST 2015

Hi Lukas,

On Tue, 6 Jan 2015 15:24:16 +0100, Lukas Slebodnik
<lslebodn at redhat.com> wrote:

> Could you take a look into https://bugzilla.samba.org/show_bug.cgi?id=11033?
> I might be wrong, but I suspect problem is caused by these patches.

Well, the problem is really caused by a dependency on broken public
headers that don't define what they use.  ;-)

samba_util.h is included and it uses DEBUG(), so DEBUG() really needs
to be defined.  Using Samba public headers that are well defined means
you will probably get some things that you don't want.

However, the solution looks fairly straightforward.  In this case,
instead of including samba_util.h, ndr.h needs to include stdbool.h,
data_blob.h, and util/time.h.  However, it seems difficult to get this
right while we have our own "time.h".  That should probably be renamed
to util_time.h.  I'll take a look again tonight.

A workaround might be to reorder your includes and conditionally #undef
DEBUG() before you define your own version.

As I said, I'll take another look at it tonight.

peace & happiness,

More information about the samba-technical mailing list