[PATCH] New VFS Module "unityed_media" for sharing AVID projects

Ralph Böhme rb at sernet.de
Tue Jan 6 10:21:27 MST 2015


On Tue, Jan 06, 2015 at 09:19:14AM -0800, Jeremy Allison wrote:
> On Tue, Jan 06, 2015 at 06:14:40PM +0100, Ralph Böhme wrote:
> > Hi Jeremy,
> > 
> > thanks for looking into this one!
> > 
> > On Mon, Jan 05, 2015 at 02:35:30PM -0800, Jeremy Allison wrote:
> > > > updated patch attached.
> > > 
> > > Looks much better, but there's still some cruft
> > > in the pathname processing probably left over
> > > from the original code implementation.
> > > 
> > > For example: is_in_media_dir() it looks for
> > > "./" and "../" - these are stripped out in
> > > source3/smbd/reply.c:check_path_syntax_internal()
> > > (and have been for may years :-).
> > 
> > Actually, I'm not so sure. I specifically asked a questino wrt to this
> > back in October:
> > <https://lists.samba.org/archive/samba-technical/2014-October/103197.html>
> > 
> > :)
> > 
> > I seem to remember that I most certainly saw paths starting with "./"
> > and the whole thing fell apart when I removed those extra checks from
> > the module.
> 
> That shouldn't happen of course :-). Can you remove
> the checks once it's in and add abort() instead so
> I can figure out where these things are coming from ?

Sure!

-Ralph

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de,mailto:kontakt@sernet.de


More information about the samba-technical mailing list