Samba 4.2.0rc3 regression: bug 10940

[Volker Lendecke]

On Mon, Jan 05, 2015 at 12:04:14PM +0100, Stefan (metze) Metzmacher wrote:
> Am 24.12.2014 um 16:50 schrieb Jeremy Allison:
> > On Wed, Dec 24, 2014 at 12:51:51PM +0100, Roel van Meer wrote:
> >> Hi list, Andrew,
> >>
> >> while testing Samba 4.2.0rc[23], I came across a problem where a
> >> code cleanup patch broke basic functionality, e.g. the ability to
> >> connect to a share on a PDC setup. This had already been reported in
> >> bug https://bugzilla.samba.org/show_bug.cgi?id=10940, with different
> >> symptoms.
> >>
> >> The patch that broke things is trivial, and reverting it fixes the problems:
> >> https://lists.samba.org/archive/samba-technical/2014-September/102319.html
> >>
> >> This might be something to look at before 4.2.0 final is released.
> >>
> >>
> >> Since this is not a trivial problem, and the bug didn't seem to have
> >> been looked at yet, I thought I'd mention it here.
> >>
> >> Happy holidays and thanks for all the good work!
> > 
> > Thanks a *LOT* for testing this Roel.
> > 
> > Looks like Metze has a fix for this we can
> > get into master and 4.2.0 final.
> > 
> > Merry Christmas and thanks for working on
> > it at this time of year :-).
> 
> Can someone please review/push the attached fix?

Pushed.

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de