[PATCH 0/3] drop the SPOOLSS_BUFFER_OK macro

Andreas Schneider asn at samba.org
Mon Jan 5 00:25:56 MST 2015

On Friday 19 December 2014 18:50:57 Guenther Deschner wrote:
> Sorry David, NAK on these as well :)
> The macros have been invented just for the purpose of avoiding to put
> manual checks everywhere. If you see a problem with the macros we
> should better fix them but please let's not go down the road again of
> putting all these checks back in the spoolss server explicitly.

The macros are more or less only used in a very few cases. I would prefer to 
get rid of them cause they do not make the code more readable. The opposite is 
the case.

Please reconsider!

	-- andreas

Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org

More information about the samba-technical mailing list