[PATCH] DFS referral shuffling

David Disseldorp ddiss at suse.de
Thu Feb 26 16:19:17 MST 2015

On Thu, 26 Feb 2015 20:21:51 +0000, Robin McCorkell wrote:

> > Opening bracket should be on a new line for functions.
> > FWIW, this Fisher-Yates shuffle isn't DFS referral specific, so should
> > probably be renamed as such.
> >  
> Should I move the shuffle code to a utility file, such as
> lib/util/util_strlist.c ? I can see this
> function being useful in other places too...

I don't have a strong preference, I'd probably keep it static in the
same file for now.

Cheers, David
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150227/37e9f291/attachment.pgp>

More information about the samba-technical mailing list