[PATCHES] Build pytalloc for two Python versions at once, port to py3
abartlet at samba.org
Thu Feb 26 15:36:00 MST 2015
On Thu, 2015-02-26 at 12:23 +0100, Petr Viktorin wrote:
> On 02/25/2015 07:53 PM, Andrew Bartlett wrote:
> > As examples, I'm particularly concerned with what the interface for and
> > user users of our ldb and ndr generated code will look like.
> > In particular, in ldb, we transport binary data and string data in the
> > same ldb_val structures, and other than by convention and schema, there
> > is no indication as to what one might find, yet adding binary2unicode
> > conversions all over all our scripts would be a total nightmare.
> I understand the concern, the unicode/bytes split will undoubtedly be
> the hardest part of the port.
> But that's part of the reason why I chose talloc, which doesn't deal
> with strings, to get the buildsystem changes down. IOW, this is not
> about the ldb/ndr interfaces.
> My assumption here is that Samba will need to port eventually, so there
> will be some time when we need to build for both 2 and 3 at the same
> time, at least for some parts. I believe that is true regardless of how
> (for example) the bytes/unicode split is handled. Do you have a
> different opinion here?
I would really like to see how that can be handled. The issue is, if
that can't be handled well, then we will have all this porting
infrusturcutre, and an expectation that we are open to a further move,
without that actually being the case. How the string handling works out
really is a blocker for me on this, I would rather Samba be python2
forever than get this wrong.
We have the luxuary of time in our spot in the ecosystem, and while I'm
very hesitant to turn down good work, I'm also really keen to continue
to wait until the environment improves, as it seems to have slowly been
> I'd really like to have the buildsystem changes vetted before I tackle
> the split, so I (and also the future reviewers) can focus on the porting
That's understandable. I'm hoping Jelmer might post some thoughts. He
and I came up with a reasonable set of expectations in some private
mails going back and forth on this.
Can you remind me what we agreed, so we can put it to the rest of the
list for their thoughts?
Authentication Developer, Samba Team http://samba.org
Samba Developer, Catalyst IT http://catalyst.net.nz/services/samba
More information about the samba-technical