[PATCH] libsmb: Make "ip_service_compare" static

Volker Lendecke Volker.Lendecke at SerNet.DE
Thu Feb 26 13:09:32 MST 2015


Hi!

Refactoring, this time just in source3/...

Review&push appreciated!

Thanks,

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de
-------------- next part --------------
From 6ec4d79b7dcfbbc005f7bf8fb1ac46d7ac7d5c53 Mon Sep 17 00:00:00 2001
From: Volker Lendecke <vl at samba.org>
Date: Wed, 25 Feb 2015 21:17:57 +0000
Subject: [PATCH] libsmb: Make "ip_service_compare" static

Signed-off-by: Volker Lendecke <vl at samba.org>
---
 source3/include/proto.h    | 1 -
 source3/libsmb/namequery.c | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/source3/include/proto.h b/source3/include/proto.h
index 82b2fb5..64bce03 100644
--- a/source3/include/proto.h
+++ b/source3/include/proto.h
@@ -821,7 +821,6 @@ bool name_status_find(const char *q_name,
 			int type,
 			const struct sockaddr_storage *to_ss,
 			fstring name);
-int ip_service_compare(struct ip_service *ss1, struct ip_service *ss2);
 int remove_duplicate_addrs2(struct ip_service *iplist, int count );
 struct tevent_req *name_query_send(TALLOC_CTX *mem_ctx,
 				   struct tevent_context *ev,
diff --git a/source3/libsmb/namequery.c b/source3/libsmb/namequery.c
index c80e255..275947e 100644
--- a/source3/libsmb/namequery.c
+++ b/source3/libsmb/namequery.c
@@ -1055,7 +1055,7 @@ static int addr_compare(const struct sockaddr_storage *ss1,
  compare 2 ldap IPs by nearness to our interfaces - used in qsort
 *******************************************************************/
 
-int ip_service_compare(struct ip_service *ss1, struct ip_service *ss2)
+static int ip_service_compare(struct ip_service *ss1, struct ip_service *ss2)
 {
 	int result;
 
-- 
1.9.1



More information about the samba-technical mailing list