[PATCH] lib/util: Build iov_buf library only when building samba
amitay at gmail.com
Thu Feb 26 06:06:16 MST 2015
On Thu, Feb 26, 2015 at 11:11 PM, Michael Adam <obnox at samba.org> wrote:
> On 2015-02-26 at 11:00 +0100, Michael Adam wrote:
> > On 2015-02-26 at 10:51 +0100, Volker Lendecke wrote:
> > > Tough problem, but as it how happened the second time in quick
> > > we need a more general solution. If we can't solve this, we are really
> > > stuck with what we have now and need to just give up on refactoring.
> > Well. I think the case at hand is different. It is just internal.
> > And the fix for that was not reverting a change but making a
> > small change to the build script.
> One could even go a step further (as indicated by metze on a
> side-track): Since this problem only occurred in an RPM build and
> not in our autobuild's standalone build (and assuming it can be
> fixed with some adaption to the configure command line) shouldn't
> we rather than talking about reverting your change revert the
> splitting of the libraries in our build system as a special case
> for ctdb's standalone RPM build and instead adapt spec files
> (and have packagers adapt spec files) ? That would be logical to
> me. (Maybe I don't understand it fully yet...)
> After all: why would one want to package CTDB separately from
> master/4.2 any more? After all Amitay has made a strong case
> of only building and running Samba with the shipped ctdb version.
The reason I still want to be able to build standalone CTDB is to be able
to automated cluster builds and nightly tests. This is much easier when
building RPMs. That's how we noticed that the packaging was broken with
the latest origin-master.
After converting to waf build all the makerpms scripts in packaging are
currently broken. There is no other way to build samba+ctdb RPMs. Till
that is resolved I would prefer to retain the ability to build CTDB rpms.
So even though we are not going to package CTDB independently it is very
useful to build CTDB rpms for continuous testing.
More information about the samba-technical