[PATCH] lib/util: Build iov_buf library only when building samba
obnox at samba.org
Thu Feb 26 04:00:20 MST 2015
On 2015-02-26 at 11:42 +0100, Volker Lendecke wrote:
> On Thu, Feb 26, 2015 at 11:00:50AM +0100, Michael Adam wrote:
> > Well. I think the case at hand is different. It is just internal.
> > And the fix for that was not reverting a change but making a
> > small change to the build script. That should not have stepped
> > on your toes so badly.
> Nobody stepped on my toes. I stepped on other's toes with my refactorings
> that don't get us any more functionality.
But you are the only one behaving like having the toes being
stepped upon... :)
> In my personal view both the debug changes and the iov_buf
> changes clean up code,
The do indeed. And I guess that is why nobody (except you)
requested to revert them.
> but if this completely non-functional cleanup comes at the cost
> of breaking our consumers, we should really reconsider our
> policy about refactoring.
No. As I said in my other mail, the consumers need to adapt
if they consume non-public stuff, or else the can request
some change in treatment of that stuff. But unless this happens,
I would consider all such refactoring highly desirable. :-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: not available
More information about the samba-technical