[PATCH] lib/util: Build iov_buf library only when building samba

Martin Schwenke martin at meltin.net
Thu Feb 26 01:57:13 MST 2015

On Thu, 26 Feb 2015 21:40:59 +1300, Andrew Bartlett
<abartlet at samba.org> wrote:

> On Thu, 2015-02-26 at 11:52 +1100, Amitay Isaacs wrote:

> > Adding new libraries in lib/util at the wrong place in wscript breaks
> > standalone ctdb rpm build.
> > 
> > Here's a patch to fix this.
> > 
> > Please review and push if ok.

> We really need to have an autobuild rule for major build modes like this
> (major in the sense of most of the common build roles, as compared with
> the minor modes arising from every possible build combination). 
> That is why we do a build with all bundled libraries, and then one where
> we build all the libraries as system libs, and link against them.
> Perhaps you are just missing ctdb from that samba-libs rule?

Autobuild does do a standalone CTDB build and runs the CTDB test

This problem was a bit subtler, so it would be hard to try to catch in
autobuild. During a CTDB RPM build the new private library was built and
installed, and then it fell over at the last hurdle due to an
unpackaged file (libiov-buf-ctdb.so, I think).  Testing that in
autobuild is probably over the top.

Perhaps I should produce a patch that adds some comments to
lib/util/wscript_build, politely asking those editing the file to add
new private libraries in the section that starts with:

  if not bld.env.SAMBA_UTIL_CORE_ONLY:

At least then this would be clearly documented.

This is more my fault that Volker's because I've introduced an
unnatural division in lib/util/wscript_build.  Having done that, I
should have clearly documented it.

Unless someone thinks I'm crazy (in this particular respect ;-) then
I'll do that tomorrow...

peace & happiness,

More information about the samba-technical mailing list