[PATCH] libwbclient clear pointer on bad read

Volker Lendecke Volker.Lendecke at SerNet.DE
Tue Feb 24 04:17:12 MST 2015


On Mon, Feb 23, 2015 at 01:18:39AM +0000, Matthew Newton wrote:
> Hi,
> 
> On Tue, Jan 27, 2015 at 09:27:14PM +0100, Volker Lendecke wrote:
> > On Tue, Jan 27, 2015 at 09:26:06PM +0100, Stefan (metze) Metzmacher wrote:
> > > Maybe
> > > 
> > > struct wbcContext *ctx = NULL;
> > > 
> > > ...
> > > 
> > > ctx = wbcCtxCreate();
> > > 
> > > ...
> > > 
> > > err = wbcCtxAuthenticateUserEx(ctx, &authparams, &info, &error);
> > > 
> > > ...
> > > 
> > > wbcCtxFree(ctx);
> ...
> > 
> > Looks good to me from a naming perspective :-)
> 
> Well, after life got in the way for a bit, I've managed to spend a
> few evenings and finally worm on this. The patch is (obviously)
> quite a lot bigger than before, but hopefully still fairly clear.

Yes, this looks very, very good!

A few comments will follow.

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de


More information about the samba-technical mailing list