[PATCH] libwbclient clear pointer on bad read

Jeremy Allison jra at samba.org
Mon Feb 23 12:27:16 MST 2015


On Mon, Feb 23, 2015 at 01:18:39AM +0000, Matthew Newton wrote:
> Hi,
> 
> On Tue, Jan 27, 2015 at 09:27:14PM +0100, Volker Lendecke wrote:
> > On Tue, Jan 27, 2015 at 09:26:06PM +0100, Stefan (metze) Metzmacher wrote:
> > > Maybe
> > > 
> > > struct wbcContext *ctx = NULL;
> > > 
> > > ...
> > > 
> > > ctx = wbcCtxCreate();
> > > 
> > > ...
> > > 
> > > err = wbcCtxAuthenticateUserEx(ctx, &authparams, &info, &error);
> > > 
> > > ...
> > > 
> > > wbcCtxFree(ctx);
> ...
> > 
> > Looks good to me from a naming perspective :-)
> 
> Well, after life got in the way for a bit, I've managed to spend a
> few evenings and finally worm on this. The patch is (obviously)
> quite a lot bigger than before, but hopefully still fairly clear.
> 
> I've broken it down into six separate patches - I'll send them as
> a series to the list rather than attaching to this e-mail. Hope
> that's OK!

I'll review - but (personally) I prefer one attachment
to the email (lots of email about that recently :-).


More information about the samba-technical mailing list