All rename paths go through rename_internals_fsp -- low hanging fruit on my quest to add an FSP to VFS functions that deal with files
realrichardsharpe at gmail.com
Sat Feb 21 15:34:56 MST 2015
I am trying to ensure that all VFS functions that deal with files are
passed an FSP.
I noticed that all rename paths go through rename_internals_fsp which
This means that the rename function can be handed an FSP.
Does anyone object to me making this change while I look at how to add
FSPs to other functions, like:
SMB_VFS_STAT although maybe all should use SMB_VFS_FSTAT
SMB_VFS_CHMOD although maybe all should use SMB_VFS_FCHMOD
SMB_VFS_CHOWN although maybe all should use SMB_VFS_FCHOWN
Actually, it turns out that SMB_VFS_NTIMES is also low-hanging fruit
because it is only called by file_ntimes and in both cases the callers
of this function are passed an fsp! Hmmm, except one of them might be
passed NULL in the fsp!
More information about the samba-technical