[Volker.Lendecke at SerNet.DE: Re: [PATCH] Bug 11092 - texpect requires routines err and errx]

[Thomas Schulz]

> On Tuesday 17 February 2015 14:54:00 Volker Lendecke wrote:
> > Crap. Reply-to to old mails is not a good idea if
> > listservers are changed :-((((
> > 
> > Volker
> > 
> > ----- Forwarded message from Volker Lendecke <Volker.Lendecke at SerNet.DE>
> > -----
> > 
> > Date: Tue, 17 Feb 2015 14:45:33 +0100
> > From: Volker Lendecke <Volker.Lendecke at SerNet.DE>
> > To: Jeremy Allison <jra at samba.org>
> > Cc: samba-technical at samba.org
> > Subject: Re: [PATCH] Bug 11092 - texpect requires routines err and errx
> > 
> > On Fri, Feb 13, 2015 at 03:11:07PM -0800, Jeremy Allison wrote:
> > > Can I get a second Team reviewer please ?
> > > 
> > > Jeremy.
> > > 
> > > From 00a3f478135a84710769c2d69dc590918d3128dd Mon Sep 17 00:00:00 2001
> > > From: Tom Schulz <schulz at adi.com>
> > > Date: Fri, 13 Feb 2015 13:47:14 -0800
> > > Subject: [PATCH] lib: texpect. Fix the build on Solaris.
> > > 
> > > Bug 11092 - texpect requires routines err and errx
> > > 
> > > https://bugzilla.samba.org/show_bug.cgi?id=11092
> > > 
> > > Signed-off-by: Tom Schulz <schulz at adi.com>
> > > Reviewed-by: Jeremy Allison <jra at samba.org>
> > 
> > To be honest, I'd like to see less use of ccan, not more.
> > Can't we replace the err and errx calls with DEBUG? DEBUG is
> > not really heavy-weight these days anymore. If that's not
> > possible for some reason, this patch certainly gets my R-B.
> > 
> > Volker

There are also versions of err and errx in libroken-samba4.so with
err.h in bin/default/source4/heimdal/lib/roken/err.h

> 
> Metze asked for an import of pyexpect. So I guess we will soon replace texpect 
> with pyexpect. Our blackbox tests should be written in python maybe with 
> py.test instead of bash hacking :)
> 
> 	-- andreas
> 
> -- 
> Andreas Schneider                   GPG-ID: CC014E3D
> Samba Team                             asn at samba.org
> www.samba.org
> 

Tom Schulz
Applied Dynamics Intl.
schulz at adi.com