[Volker.Lendecke at SerNet.DE: Re: [PATCH] Bug 11092 - texpect requires routines err and errx]

[Volker Lendecke]

Crap. Reply-to to old mails is not a good idea if
listservers are changed :-((((

Volker

----- Forwarded message from Volker Lendecke <Volker.Lendecke at SerNet.DE> -----

Date: Tue, 17 Feb 2015 14:45:33 +0100
From: Volker Lendecke <Volker.Lendecke at SerNet.DE>
To: Jeremy Allison <jra at samba.org>
Cc: samba-technical at samba.org
Subject: Re: [PATCH] Bug 11092 - texpect requires routines err and errx

On Fri, Feb 13, 2015 at 03:11:07PM -0800, Jeremy Allison wrote:
> Can I get a second Team reviewer please ?
> 
> Jeremy.

> From 00a3f478135a84710769c2d69dc590918d3128dd Mon Sep 17 00:00:00 2001
> From: Tom Schulz <schulz at adi.com>
> Date: Fri, 13 Feb 2015 13:47:14 -0800
> Subject: [PATCH] lib: texpect. Fix the build on Solaris.
> 
> Bug 11092 - texpect requires routines err and errx
> 
> https://bugzilla.samba.org/show_bug.cgi?id=11092
> 
> Signed-off-by: Tom Schulz <schulz at adi.com>
> Reviewed-by: Jeremy Allison <jra at samba.org>

To be honest, I'd like to see less use of ccan, not more.
Can't we replace the err and errx calls with DEBUG? DEBUG is
not really heavy-weight these days anymore. If that's not
possible for some reason, this patch certainly gets my R-B.

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de

----- End forwarded message -----

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de