[PATCH 0/2] remove small_query from the SMB_VFS_DISK_FREE() code path

Jeremy Allison jra at samba.org
Mon Feb 16 18:35:49 MST 2015

On Mon, Feb 16, 2015 at 07:26:22PM +0100, David Disseldorp wrote:
> The small_query parameter for SMB_VFS_DISK_FREE() and friends only
> exists to squash free space values down to 16-bits for the deprecated
> dskattr command response.
> This patch set moves the 16-bit squash logic out of the VFS and into the
> dskattr handler code, where it is better suited.
> Feedback appreciated.

*Really* nice cleanup - pushed. Thanks !

Only one thing, if we ship 4.2.0 as VFS version 32,
we'll need to update this in master to 33 ensure the
version containing this change isn't confused with
the 4.2.0 VFS version.

If you're not planning to get this into 4.2.x, then
I'd add my 'Reviewed-by' to a patch that updates the
version to 33 for this change.

More information about the samba-technical mailing list