[RFC] Patchsets in a single mail? [Re: [PATCH 01/55] Add simple subunit runner outputting subunit v1.]

David Disseldorp ddiss at suse.de
Sun Feb 15 12:36:28 MST 2015

On Sun, 15 Feb 2015 19:46:00 +0100, Michael Adam wrote:

> Well the granularity is not lost if I attach the whole
> patchset to a mail. The individual patches are not squashed
> or so. But it is possible (in contrast to the one mail per
> commit approach) to reply in a broader context.

The "git send-email --compose" introductory mail is ideal for a broad
context reply.

> I can't emphasise enought the point that for me a patchset
> sent to the list should be form a logical unit. Some comments
> may apply to several patches in the series and may provoke
> changes to several commits. This is just intractable for my
> poor brain in the multi-mail mode. But I am trying. ;)
> Again, I guess we should just continue as is. Everybody sends the
> patches the way (s)he likes (single/multi mail). People are just
> different, and so are their preferences.

In the end I want to make it as easy for reviewers as possible, so if
the majority prefer not to have inline patch-sets, then I guess I'll
have to consider changing.

Cheers, David
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150215/e916f737/attachment.pgp>

More information about the samba-technical mailing list