[RFC] Patchsets in a single mail? [Re: [PATCH 01/55] Add simple subunit runner outputting subunit v1.]

Simo simo at samba.org
Fri Feb 13 16:00:47 MST 2015


On Fri, 2015-02-13 at 13:57 -0800, Jeremy Allison wrote:
> On Fri, Feb 13, 2015 at 09:24:28PM +0100, Michael Adam wrote:
> > 
> > So I would really really appreciate if people send
> > patchsets in a single mail. There are (at least)
> > two ways to do that:
> > 
> > 1) Do git format-patch HASH1^..HASH2
> >    and attach all patch files produced to
> >    a mail with a meaningful intro to the patchset.
> > 
> > 2) Do git format-patch --stdout HASH1^..HASH2 > my.patches
> >    and attach my.patches to a mail with a meaningful
> >    intro to the patchset.
> > 
> > Of these I greatly favour number 2, since for variant 1
> > you again have the problem of saving and applying 55 single
> > patch files, so let's forget about #1.
> 
> +1 from me. I even find David's split out patchsets a pain
> to deal with.
> 
> Why people send multi-mail patchsets I can't understand :-(.

Because they have mail clients that make it easy to deal with them :-)

But it is just a matter of convention, it seem people on this list that
are very active reviewers find it difficult, so perhaps we should steer
towards one patchset per email.

Simo.
-- 
Simo Sorce



More information about the samba-technical mailing list